Open
Conversation
typescript-bot
added
the
For Milestone Bug
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Diagnostic code
Fix diagnostic code 69010 typo to 6910
Jul 7, 2025
69010 may be typo of 6910?
Member
|
Not ideal to edit the lcl files but it doesn't really matter. LGTM. Edit: Nah let's keep the git history clean on those |
RyanCavanaugh
approved these changes
Jul 7, 2025
RyanCavanaugh
requested changes
Jul 7, 2025
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Revert all changes to the LCL files, these should not be edited by us
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
Reverted all LCL file changes as requested. The main diagnosticMessages.json file still contains the fix (code 6910), but all LCL files have been restored to their original state. dc0ec58 |
RyanCavanaugh
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the diagnostic code from 69010 to 6910 in the diagnosticMessages.json file.
Issue
The diagnostic message
"module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"had code 69010, which appears to be a typo based on the sequential numbering pattern of surrounding diagnostic codes:"trueifcomposite,falseotherwise""module === 'AMD' or 'UMD' or 'System' or 'ES6', then 'Classic', Otherwise 'Node'"← Should be 6910"Computed from the list of input files""Platform specific"Changes Made
src/compiler/diagnosticMessages.jsonsrc/loc/lcl/to use the correct code 6910Verification
The fix is minimal and surgical - only changing the diagnostic code number while preserving all functionality and maintaining the sequential numbering pattern.
Fixes #61971.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.