Allow trailing commas after import attributes in ImportType#61920
Merged
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom Jun 24, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables a trailing comma after the import attributes object in import(...) types and adds tests to verify valid and invalid comma placements.
- Allow an optional comma before closing the import-attributes argument.
- Add new test cases covering no comma, one trailing comma, and double-comma errors.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/conformance/importAttributes10.ts | New tests for import attributes with single and double commas |
| src/compiler/parser.ts | Insert parseOptional(SyntaxKind.CommaToken) before } |
Member
|
@Andarist I'm going to assign the issue to copilot just for analysis purposes. No shade on this fix, which appears correct (but let's not tell the computer that) |
RyanCavanaugh
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #61916