[WIP] Symbol properties on objects are imported by type and not by value when auto-completed

[Copilot]

• Analyze the issue: Symbol properties on objects are imported by type instead of value when auto-completed
• Explore repository structure and build system
• Create a fourslash test to reproduce the bug
• Run the test to verify it fails
• Identify the root cause in the language service
• Fix the bug
• Verify the fix works
• Run all tests to ensure no regressions
• Format and lint code

Root Cause: When there's an existing type-only import, the auto-import system incorrectly adds value imports to it instead of creating mixed imports or separate imports.

Fix: Modified tryAddToExistingImport in importFixes.ts to:

1. Only return perfect matches for type-only requirements (Required+TypeOnly or NotAllowed+Value)
2. Skip incompatible combinations (value imports going to type-only imports)
3. Handle cases where addAsTypeOnly is Allowed but should prefer value imports

Testing: Verified that completely disabling existing import addition fixes the issue (creates separate imports). The targeted fix is in the right location but may need refinement.

Test Case: Simple case that reproduces the issue:

import type { SomeType } from "./exports";  // existing type-only
VALUE;  // auto-complete this → should create mixed/separate import

Fixes #61894.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[RyanCavanaugh]

@copilot you're almost there! Keep going

[Copilot]

@copilot you're almost there! Keep going

Thanks for the encouragement! I'm working on refining the fix. The logic is in the right place but I need to debug why value imports are still being added to type-only imports. I'll continue iterating on the solution.

[RyanCavanaugh]

@copilot keep going

[Copilot]

@copilot keep going

I'm debugging why the value import is still being added to the type-only import. The fix should prevent this but VALUE is still ending up in the type-only import instead of creating a mixed import. Investigating the control flow.

[RyanCavanaugh]

The ideal fix looks like

// From
import type { Foo } from "./bar";
// to
import { Baz, type Foo } from "./bar";

but it kept coming back to a fix that produces

// From
import type { Foo } from "./bar";
// to
import type { Foo } from "./bar";
import { Baz } from "./bar";

I think it's confused because of how synthesized completion members interact with bracket vs dot notation. The likely fix is probably in completions.ts, not importFixes.