Closed
Conversation
jakebailey
reviewed
Jun 5, 2025
Comment on lines
+40619
to
+40621
| if (isBoolean(left) || isBoolean(right)) { | ||
| return true; | ||
| } |
Author
There was a problem hiding this comment.
It is unrelated, it is from my previous PR. I fetched from Main and pulled before making this commit, but I guess it was still in there. Oops, my bad. I didn't want to make this PR, I only did it for a school assignment. I was hoping this would be ignored like my last PR. I apologize for wasting your time.
RyanCavanaugh
requested changes
Jun 9, 2025
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
I haven't looked too closely at this, but this definitely must have testcases
github-project-automation
bot
moved this from Not started
to Waiting on author
in PR Backlog
Author
|
I only made this PR for a school assignment. It has been graded, so I am closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29707
Added check for unknown type to fix issue when declaring a class constructor.