Fixed (Critical null pointer bug) in incremental builder

[DrHazemAli]

Summary

This PR addresses a critical null pointer issue in TypeScript's incremental compilation builder system and fixes property mapping inconsistencies in diagnostic conversion functions.

Issues Fixed

1. Critical Null Pointer Bug in Builder System

• Location: src/compiler/builder.ts lines 643 and 2147
• Problem: state.affectedFilesIndex was accessed with non-null assertion (!) despite being defined as number | undefined in the BuilderProgramState interface
• Impact: Could cause runtime crashes when affectedFilesIndex is undefined during incremental builds
• Solution: Replaced non-null assertions with proper undefined handling using nullish coalescing (??)

2. Diagnostic Property Mapping Inconsistencies

• Location: src/compiler/builder.ts lines 577 and 1507
• Problem: Incorrect property mappings between Diagnostic and ReusableDiagnostic types:
  • Diagnostic has reportsDeprecated property
  • ReusableDiagnostic has reportDeprecated property
• Solution: Fixed property mappings in conversion functions:
  • convertToDiagnostics: diagnostic.reportDeprecated → result.reportsDeprecated
  • toReusableDiagnostic: diagnostic.reportsDeprecated → result.reportDeprecated

Technical Details

The affectedFilesIndex tracks the current position when iterating through files affected by changes in incremental compilation. The interface correctly allows this to be undefined, but the implementation incorrectly assumed it was always defined.

This bug could manifest during:

• Incremental builds when processing affected files
• Build scenarios where the affected files iteration state is reset
• Complex project builds with multiple file dependencies

Code Changes

// Before (line 643)
let affectedFilesIndex = state.affectedFilesIndex!; // TODO: GH#18217

// After (line 643)  
let affectedFilesIndex = state.affectedFilesIndex ?? 0; // Fixed: properly handle undefined case

Risk Assessment

Low Risk: Changes only affect error-prone undefined access patterns and incorrect property mappings. The fixes make the code more robust and type-safe without changing core functionality.

Consideration

The following line 644

let affectedFilesIndex = state.affectedFilesIndex!; // TODO: GH#18217

Was commented as TODO: GH#18217

Testing Notes

• Linter errors have been resolved
• Type safety improved with proper undefined handling
• Diagnostic property mappings validated for correctness
• Note: Full test suite (hereby runtests) should be run to ensure no regressions

[typescript-bot]

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

[sheetalkamat]

These changes are invariants in builder state and thats why are asserts

[DrHazemAli]

Thanks for clarifying! I see now.
However, The non-null assertions are there to catch logic errors in the calling code, not to handle undefined values.

I’ll go ahead and close this PR since the implementation is correct by design.