Match tags case-insensitively for uncommitted PRs#76
Merged
jakebailey merged 1 commit intomicrosoft:masterfrom Sep 8, 2025
Merged
Match tags case-insensitively for uncommitted PRs#76jakebailey merged 1 commit intomicrosoft:masterfrom
jakebailey merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
jakebailey
approved these changes
Sep 8, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Seems fine. This repo doesn't do anything with typescript-go, and probably will never given that repo will be archived once we transfer its contents into the main TS repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request for an issue I'm following received a comment (microsoft/TypeScript#62323 (comment)) saying the linked issue hasn't been committed. However, the linked issue (microsoft/TypeScript#58561) seems to be committed, and properly marked as such. I suppose
help wantedwas changed toHelp Wantedin the repo at some point in time.We could of course just fix the case of the one string literal, let me know if that's preferred. It just felt prudent to switch to a case-insensitive comparison, e.g. in case the check gets used in other repos (I noticed microsoft/typescript-go uses the lowercase tag name).
There are other label checks in the codebase that are case sensitive, let me know if you'd like me to touch those as well. I left them as they are for now.