Skip to content

Add stack-lifetime-hazards taxonomy declarations to existing templates#41

Merged
Alan-Jowett merged 2 commits intomainfrom
copilot/add-taxonomy-declarations-to-templates
Mar 20, 2026
Merged

Add stack-lifetime-hazards taxonomy declarations to existing templates#41
Alan-Jowett merged 2 commits intomainfrom
copilot/add-taxonomy-declarations-to-templates

Conversation

Copy link
Contributor

Copilot AI commented Mar 20, 2026

PR #35 wired up taxonomy assembly in the CLI but three templates (investigate-bug, investigate-security, review-code) listed in stack-lifetime-hazards.applicable_to never declared the taxonomy in their frontmatter, so the H1–H5 hazard class definitions were silently omitted from assembled prompts.

Changes

  • Template frontmatter — added taxonomies: [stack-lifetime-hazards] to investigate-bug.md, investigate-security.md, and review-code.md
  • manifest.yaml — added matching taxonomies: [stack-lifetime-hazards] entries for all three templates, consistent with the pattern established by audit-traceability
# Before
protocols: [anti-hallucination, self-verification, operational-constraints, root-cause-analysis]
format: investigation-report

# After
protocols: [anti-hallucination, self-verification, operational-constraints, root-cause-analysis]
taxonomies: [stack-lifetime-hazards]
format: investigation-report

tests/validate-manifest.py passes unchanged (it validates protocol sync; taxonomy sync follows the same structural convention).

Original prompt

This section details on the original issue you should resolve

<issue_title>Add taxonomy declarations to existing templates</issue_title>
<issue_description>## Summary

PR #35 added taxonomy support to the CLI assembler, but only the new \�udit-traceability\ template declares a \ axonomies\ field. Existing templates that use the \stack-lifetime-hazards\ taxonomy should also declare it so the taxonomy definitions are included in assembled prompts.

What to do

Add \ axonomies: [stack-lifetime-hazards]\ to the frontmatter of templates listed in the taxonomy's \�pplicable_to\ field:

  • \ emplates/investigate-bug.md\
  • \ emplates/investigate-security.md\
  • \ emplates/review-code.md\

Also add corresponding \ axonomies\ entries in \manifest.yaml\ for each template.

Why

Without this, users running \promptkit assemble investigate-bug\ don't get the H1–H5 hazard class definitions in the assembled prompt. The CLI now supports taxonomy assembly (added in PR #35) but these templates predate the feature.

Acceptance criteria

  • Three templates updated with \ axonomies\ frontmatter field
  • \manifest.yaml\ updated to match
  • \ ests/validate-manifest.py\ passes
  • Quick smoke test:
    ode -e\ confirms H1_STACK_ADDRESS_ESCAPE appears in assembled \investigate-bug\ output
    </issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ate-security, review-code templates and manifest.yaml

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Copilot AI changed the title [WIP] Add taxonomy declarations to existing templates Add stack-lifetime-hazards taxonomy declarations to existing templates Mar 20, 2026
Copilot AI requested a review from Alan-Jowett March 20, 2026 02:16
@Alan-Jowett
Copy link
Member

@copilot are these the only missing taxonomies or are others also missing them?

Copy link
Contributor Author

Copilot AI commented Mar 20, 2026

@copilot are these the only missing taxonomies or are others also missing them?

There are only two taxonomies in the repo:

  • specification-driftapplicable_to: [audit-traceability] — already had taxonomies: [specification-drift] declared (it introduced the feature)
  • stack-lifetime-hazardsapplicable_to: [investigate-bug, investigate-security, review-code] — all three are now covered by this PR

No other templates are missing taxonomy declarations.

@Alan-Jowett Alan-Jowett marked this pull request as ready for review March 20, 2026 02:41
Copilot AI review requested due to automatic review settings March 20, 2026 02:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PromptKit’s template declarations so the existing stack-lifetime-hazards taxonomy (H1–H5) is included during CLI prompt assembly for the templates that the taxonomy already declares as applicable.

Changes:

  • Added taxonomies: [stack-lifetime-hazards] to the YAML frontmatter of three existing templates.
  • Added matching taxonomies: [stack-lifetime-hazards] entries for those templates in manifest.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
templates/investigate-bug.md Declares stack-lifetime-hazards taxonomy in template frontmatter so assembled prompts include H1–H5 definitions.
templates/investigate-security.md Declares stack-lifetime-hazards taxonomy in template frontmatter for security investigations.
templates/review-code.md Declares stack-lifetime-hazards taxonomy in template frontmatter for code review prompts.
manifest.yaml Wires stack-lifetime-hazards into the three templates’ manifest entries so the CLI can resolve and inject the taxonomy section.

@Alan-Jowett Alan-Jowett merged commit 9c2b4f6 into main Mar 20, 2026
8 checks passed
@Alan-Jowett Alan-Jowett deleted the copilot/add-taxonomy-declarations-to-templates branch March 20, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add taxonomy declarations to existing templates

3 participants