Add stack-lifetime-hazards taxonomy declarations to existing templates#41
Merged
Alan-Jowett merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
…ate-security, review-code templates and manifest.yaml Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add taxonomy declarations to existing templates
Add stack-lifetime-hazards taxonomy declarations to existing templates
Mar 20, 2026
Member
|
@copilot are these the only missing taxonomies or are others also missing them? |
Contributor
Author
There are only two taxonomies in the repo:
No other templates are missing taxonomy declarations. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates PromptKit’s template declarations so the existing stack-lifetime-hazards taxonomy (H1–H5) is included during CLI prompt assembly for the templates that the taxonomy already declares as applicable.
Changes:
- Added
taxonomies: [stack-lifetime-hazards]to the YAML frontmatter of three existing templates. - Added matching
taxonomies: [stack-lifetime-hazards]entries for those templates inmanifest.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/investigate-bug.md | Declares stack-lifetime-hazards taxonomy in template frontmatter so assembled prompts include H1–H5 definitions. |
| templates/investigate-security.md | Declares stack-lifetime-hazards taxonomy in template frontmatter for security investigations. |
| templates/review-code.md | Declares stack-lifetime-hazards taxonomy in template frontmatter for code review prompts. |
| manifest.yaml | Wires stack-lifetime-hazards into the three templates’ manifest entries so the CLI can resolve and inject the taxonomy section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #35 wired up taxonomy assembly in the CLI but three templates (
investigate-bug,investigate-security,review-code) listed instack-lifetime-hazards.applicable_tonever declared the taxonomy in their frontmatter, so the H1–H5 hazard class definitions were silently omitted from assembled prompts.Changes
taxonomies: [stack-lifetime-hazards]toinvestigate-bug.md,investigate-security.md, andreview-code.mdmanifest.yaml— added matchingtaxonomies: [stack-lifetime-hazards]entries for all three templates, consistent with the pattern established byaudit-traceabilitytests/validate-manifest.pypasses unchanged (it validates protocol sync; taxonomy sync follows the same structural convention).Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.