Update nodiscard test#8471
Merged
Merged
Conversation
This adds coverage of two uses missed in the original test. The first covers structs with nodiscard on the type declaration, the second covers selecting the method spelling of the attribute over the type attribute if both are present.
tex3d
reviewed
May 21, 2026
tex3d
approved these changes
May 21, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good, but would be nice to see a method of S without [[nodiscard]] or [[clang::warn_unused_result]] to demonstrate that no warning is generated, and this is by-design. (if that is indeed the intention)
V-FEXrt
approved these changes
May 21, 2026
V-FEXrt
approved these changes
May 21, 2026
tex3d
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds coverage of two uses missed in the original test. The first covers structs with nodiscard on the type declaration, the second covers selecting the method spelling of the attribute over the type attribute if both are present.