[SM6.10] Update Values for Component Types#8264
Open
V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
Open
[SM6.10] Update Values for Component Types#8264V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
V-FEXrt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
I8 and U8 were in an inconsistent order compared to all the other previously defined types. The values are swapped now as they were only ever used for coopvec which never left preview and is removed from future releases. The upcoming LinAlg feature will depend on these values so they must be updated now.
Member
|
I think this change breaks the contract between any drivers that implement preview cooperative vectors. Should we just do #8147 now and be done with it? |
Collaborator
Author
It does yes
We should yes, I was trying to make the minimal change needed for the LinAlg preview but we could potentially just do the larger thing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I8 and U8 were in an inconsistent order compared to all the other previously defined types. The values are swapped now as they were only ever used for coopvec which never left preview and is removed from future releases. The upcoming LinAlg feature will depend on these values so they must be updated now.