Skip to content

Centralize npm run build job #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compulim merged 9 commits into from
Mar 12, 2026
Merged

Centralize npm run build job #5776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf705bf
Ignore *.tgz
compulim Mar 11, 2026
ed24e25
Centralize npm run build
compulim Mar 11, 2026
568b1a8
Fix dependencies
compulim Mar 12, 2026
6575855
Use --call
compulim Mar 12, 2026
d872633
Quote call command
compulim Mar 12, 2026
a565026
Sort
compulim Mar 12, 2026
6a2db8b
Build browser matrix
compulim Mar 12, 2026
3cce1a4
Add extract tarballs
compulim Mar 12, 2026
58ce00f
Build cldr-data
compulim Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 63 additions & 5 deletions .github/workflows/pull-request-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,28 @@ jobs:
path: docker.zip
retention-days: 1

- name: Pack all packages
run: npm exec --workspaces -- npm pack

- name: Tar all tarballs
run: find . -type f -name '*.tgz' -not -path '*/node_modules/*' -print0 | tar --null -cvf tarballs.tar --files-from=-

- uses: actions/upload-artifact@v7
with:
compression-level: 0
name: tarballs
path: tarballs.tar
retention-days: 1

build-browser:
name: Build test harness
runs-on: windows-latest
name: Verify build-browser
strategy:
matrix:
os:
- macos-latest
- ubuntu-latest
- windows-latest
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -121,6 +140,8 @@ jobs:

static-code-analysis:
name: Static code analysis
needs:
- build # Needed for resolving dependencies across packages
runs-on: ubuntu-latest

steps:
Expand All @@ -134,12 +155,23 @@ jobs:

- run: npm clean-install --strict-peer-deps

- run: npm run build --if-present
- name: Download tarballs
uses: actions/download-artifact@v8
with:
name: tarballs

- name: Extract tarballs
run: tar -xvf tarballs.tar

- name: Unpack tarballs
run: npm exec --call 'tar --skip-old-files --strip-components=1 -xf *.tgz' --workspaces

- run: npm run precommit --if-present

unit-test:
name: Unit test
needs:
- build
runs-on: ubuntu-latest

steps:
Expand All @@ -153,7 +185,20 @@ jobs:

- run: npm clean-install --strict-peer-deps

- run: npm run build --if-present
- name: Download tarballs
uses: actions/download-artifact@v8
with:
name: tarballs

- name: Extract tarballs
run: tar -xvf tarballs.tar

- name: Unpack tarballs
run: npm exec --call 'tar --skip-old-files --strip-components=1 -xf *.tgz' --workspaces

- name: Build cldr-data # Required for unit testing
run: npm run build
working-directory: ./packages/support/cldr-data/

- name: Run jest --testPathPattern packages/
run: |
Expand Down Expand Up @@ -187,6 +232,8 @@ jobs:

type-definitions-test:
name: Type definitions test
needs:
- build
runs-on: ubuntu-latest

steps:
Expand All @@ -200,7 +247,18 @@ jobs:

- run: npm clean-install --strict-peer-deps

- run: npm run build --if-present
- name: Download tarballs
uses: actions/download-artifact@v8
with:
name: tarballs

- name: Extract tarballs
run: tar -xvf tarballs.tar

- name: Unpack tarballs
run: npm exec --call 'tar --skip-old-files --strip-components=1 -xf *.tgz' --workspaces

# - run: npm run build --if-present

- name: Run tsd under packages/bundle (CJS)
run: ../../node_modules/.bin/tsd -t ./dist/botframework-webchat.d.ts
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/__tests__/__image_snapshots__/**/__diff_output__
/__tests__/html2/**/*.snap-*-diff.png
/.env
/*.tar
/*.tgz
/coverage
/debug.log
Expand Down
7 changes: 4 additions & 3 deletions packages/isomorphic-react-dom/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/dist
/lib
/node_modules
/*.tgz
/dist/
/lib/
/node_modules/
7 changes: 4 additions & 3 deletions packages/isomorphic-react/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/dist
/lib
/node_modules
/*.tgz
/dist/
/lib/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/adaptivecards/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/base64-js/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/botframework-directlinejs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/html-react-parser/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/microsoft-cognitiveservices-speech-sdk/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/object-assign/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react-dom/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react-dom@baseline/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react-dom@umd/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react-is/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react@baseline/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/repack/react@umd/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/*.tgz
/dist/
/node_modules/
3 changes: 2 additions & 1 deletion packages/support/cldr-data-downloader/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules/
/*.tgz
/node_modules/
5 changes: 3 additions & 2 deletions packages/support/cldr-data/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/node_modules
/*.tgz
/node_modules/

# CLDR downloaded files.
/dist
/dist/
3 changes: 2 additions & 1 deletion packages/test/dev-server/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/node_modules
/*.tgz
/node_modules/
6 changes: 3 additions & 3 deletions packages/test/harness/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/dist
/lib
/node_modules
/*.tgz
/dist/
/node_modules/
6 changes: 3 additions & 3 deletions packages/test/page-object/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/dist
/lib
/node_modules
/*.tgz
/dist/
/node_modules/
1 change: 1 addition & 0 deletions packages/test/test-assets/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/*.tgz
/make.com
/node_modules/
/out/
5 changes: 3 additions & 2 deletions packages/test/web-server/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/.env*
/dist
/node_modules
/*.tgz
/dist/
/node_modules/
/serve.json
2 changes: 2 additions & 0 deletions packages/vibe-grep/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/*.tgz
/node_modules/
Loading