Skip to content

Fix unix-ffi/re: Fix OverflowError in re.groups(). #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Josverl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix unix-ffi/re: Fix OverflowError in re.groups(). #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3485edc
unix-ffe/re: Handle PCRE2_UNSET in group and groups methods.
Josverl Feb 28, 2026
8cbb7ad
unix-ffi/re: Add test for empty string match in ffi regex.
Josverl Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions unix-ffi/re/re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
# to -1
PCRE2_ZERO_TERMINATED = -1

# PCRE2_UNSET is used for offsets of groups that didn't participate in a match
# It's SIZE_MAX: 0xFFFFFFFF for 32bit, 0xFFFFFFFFFFFFFFFF for 64bit
PCRE2_UNSET = (1 << (PCRE2_SIZE_SIZE * 8)) - 1


IGNORECASE = I = 0x8
MULTILINE = M = 0x400
Expand All @@ -62,12 +66,11 @@ def group(self, *n):
if not n:
return self.s[self.offsets[0] : self.offsets[1]]
if len(n) == 1:
return self.s[self.offsets[n[0] * 2] : self.offsets[n[0] * 2 + 1]]
return tuple(self.s[self.offsets[i * 2] : self.offsets[i * 2 + 1]] for i in n)
return None if self.offsets[n[0] * 2] == PCRE2_UNSET else self.s[self.offsets[n[0] * 2] : self.offsets[n[0] * 2 + 1]]
return tuple(None if self.offsets[i * 2] == PCRE2_UNSET else self.s[self.offsets[i * 2] : self.offsets[i * 2 + 1]] for i in n)

def groups(self, default=None):
assert default is None
return tuple(self.group(i + 1) for i in range(self.num - 1))
return tuple(default if self.offsets[(i + 1) * 2] == PCRE2_UNSET else self.group(i + 1) for i in range(self.num - 1))

def start(self, n=0):
return self.offsets[n * 2]
Expand Down
3 changes: 3 additions & 0 deletions unix-ffi/re/test_re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@
text = " \thello there\n \t how are you?"
indents = _leading_whitespace_re.findall(text)
assert indents == [" \t", " \t "]

m = re.match(r"(.)?", "")
assert m.groups() == (None,)
Loading