Skip to content

feat: Add PDF, HTML, and Code file support with syntax highlighting and strict WebView2 security#30

Draft
miclat97 wants to merge 1 commit into
masterfrom
feature/webview_code_support-8287540703250467516
Draft

feat: Add PDF, HTML, and Code file support with syntax highlighting and strict WebView2 security#30
miclat97 wants to merge 1 commit into
masterfrom
feature/webview_code_support-8287540703250467516

Conversation

@miclat97

Copy link
Copy Markdown
Owner

Implemented PDF, HTML, and code file viewing functionality.

  1. Code Viewer: Added AvalonEdit integration for .json, .java, .cs, .c, .cpp, .py files to provide native syntax highlighting.
  2. PDF/HTML Viewer: Added Microsoft.Web.WebView2 integration for .pdf and .html/.htm files.
  3. Strict HTML Security:
    • Intercepts WebResourceRequested inside WebView2.
    • Completely blocks all internet requests (anything non-file:// is rejected with 403 Forbidden).
    • Introduced a new configuration setting LoadAdjacentFilesToHtml (0 = Disabled, 1 = Enabled).
    • If Disabled (0), only the exact HTML file is allowed to load. No external CSS, JS, or images are permitted.
    • If Enabled (1), the viewer allows local files loaded only from the exact same directory as the HTML file, or up to 1 subfolder deep. Attempting to traverse upwards (../) or escaping the root directory is blocked with 403 Forbidden.
  4. Settings UI: The new file extensions and the LoadAdjacentFilesToHtml setting are dynamically editable in the Settings Window.

PR created automatically by Jules for task 8287540703250467516 started by @miclat97

… local security

- Added PDF, HTML, and Code filetypes to Enum and Config.
- Integrated Microsoft.Web.WebView2 for PDF and HTML file viewing.
- Configured WebView2 to block all non-file network requests (internet access).
- Added 'LoadAdjacentFilesToHtml' setting to restrict local file access for HTML viewers either strictly to the exact file or scoped to the current directory and one level down.
- Integrated AvalonEdit for syntax highlighting of Code files (.json, .java, .cs, .c, .cpp, .py).
- Adjusted MainWindows UI logic to render these components dynamically based on file type.
- Handled async data synchronization with INotifyPropertyChanged in FileContentModel.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant