Skip to content

feat: allow using local checkouts of dependencies via env var#294

Merged
Gerrit91 merged 2 commits intomasterfrom
onboarding/localdev
Apr 28, 2026
Merged

feat: allow using local checkouts of dependencies via env var#294
Gerrit91 merged 2 commits intomasterfrom
onboarding/localdev

Conversation

@ma-hartma
Copy link
Copy Markdown
Contributor

@ma-hartma ma-hartma commented Apr 23, 2026

Description

This PR tries to improve the handling of local dependency checkouts.
Users now do not have to change the compose files when using local dependencies for e.g. metal-roles.

Part of #291

Used AI-Tools ✨

  • Claude Opus 4.7 was used for README improvements and auto-completion

@ma-hartma ma-hartma requested a review from l0wl3vel April 23, 2026 07:34
@ma-hartma ma-hartma force-pushed the onboarding/localdev branch 3 times, most recently from e862ed5 to 2947d3c Compare April 23, 2026 08:42
@ma-hartma ma-hartma marked this pull request as ready for review April 23, 2026 08:48
@ma-hartma ma-hartma requested a review from a team as a code owner April 23, 2026 08:48
@ma-hartma ma-hartma force-pushed the onboarding/localdev branch from 2947d3c to e5e325c Compare April 23, 2026 09:39
Copy link
Copy Markdown

@l0wl3vel l0wl3vel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A bit verbose with the overlays but will do the trick for now

@ma-hartma
Copy link
Copy Markdown
Contributor Author

ma-hartma commented Apr 23, 2026

Thanks, unfortunately I haven't found an option to make this less verbose so this is the solution I ended up with.
It seems like there is no support for this in docker:

  • we can't use -v with docker compose up
  • there are no optional volumes

See: docker/compose#3979

@ma-hartma ma-hartma requested a review from vknabel April 27, 2026 07:23
Comment thread Makefile
@Gerrit91 Gerrit91 merged commit 41fab66 into master Apr 28, 2026
13 of 15 checks passed
@Gerrit91 Gerrit91 deleted the onboarding/localdev branch April 28, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants