Conversation
vknabel
force-pushed
the
typescript-example
branch
from
7e19069 to
ee161d7
Compare
majst01
approved these changes
Feb 12, 2026
ostempel
reviewed
Feb 12, 2026
Contributor
ostempel
left a comment
ostempel
left a comment
There was a problem hiding this comment.
I think we can remove npm scripts
Comment on lines
+7
to
+10
| "scripts": { | ||
| "build": "tsc --project tsconfig.json", | ||
| "ip-list": "npm run build && node ./ip-list.js" | ||
| }, |
Contributor
There was a problem hiding this comment.
since we use bun I don't think we need this. bun supports out of the box execution of .ts files and transpiles them on the fly
Contributor
There was a problem hiding this comment.
I would stick with npm, because these are examples and most end users know npm better than bun. How we build the project is obviously something different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
None