Add sensor-config commands [guidance needed) #903
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to add sensor configuration commands for the new sensors implemented in the Air Quality module and which available configs are in the
admin.protoalready: https://github.com/meshtastic/protobufs/blob/master/meshtastic/admin.proto#L644-L654However, I have the feeling that I am doing something wrong while parsing the options, as I assume there must be some sort of better option than manually typing all of them... (see https://github.com/fablabbcn/meshtastic-python/blob/b54ac0e0f0aaee60c5a54069e47bbb6c7818447a/meshtastic/node.py#L980-L1021)
An example of what I am doing to test this is:
Which successfully reaches the node and gets processed via
admincommand.