-
Notifications
You must be signed in to change notification settings - Fork 22
[WTF-2710]: Fix unit tests failing on ValueStatus import #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alihcsumer
wants to merge
5
commits into
master
Choose a base branch
from
wtf/fixunittestimports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3fde057
Mock mendix runtime enums in web jest config
alihcsumer 102e7df
Review: Refactor based on !192
alihcsumer 0902ea8
Update the change log
alihcsumer e86e0ae
Check types for mocks
alihcsumer c624499
Review: Inline the typecheck for the test exports
alihcsumer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
packages/pluggable-widgets-tools/test-config/__mocks__/mendix.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // @ts-check | ||
| // Runtime mock for the types-only `mendix` package (its real entry throws). | ||
| // Stays plain JS because it ships inside the consumer's node_modules, where | ||
| // jest won't transform TypeScript. The JSDoc `@type` annotations check the | ||
| // values against `mendix`'s types (repo-only, via test-config/tsconfig.json) | ||
| // and are erased at runtime. | ||
|
|
||
| /** @typedef {typeof import("mendix")} MendixModule */ | ||
|
|
||
| /** | ||
| * Map an enum's type to `{ [Member]: itsStringValue }`. | ||
| * @template E | ||
| * @typedef {{ [K in keyof E]: `${Extract<E[K], string>}` }} EnumMock | ||
| */ | ||
|
|
||
| module.exports = { | ||
| /** @type {EnumMock<MendixModule["ValueStatus"]>} */ | ||
| ValueStatus: { | ||
| Available: "available", | ||
| Unavailable: "unavailable", | ||
| Loading: "loading" | ||
| }, | ||
| /** @type {EnumMock<MendixModule["FormatterType"]>} */ | ||
| FormatterType: { | ||
| Number: "number", | ||
| DateTime: "datetime" | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
packages/pluggable-widgets-tools/test-config/tsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "extends": "../configs/tsconfig.base", | ||
| "compilerOptions": { | ||
| "noEmit": true, | ||
| "allowJs": true, | ||
| "checkJs": true, | ||
| "moduleResolution": "bundler" | ||
| }, | ||
| "include": ["__mocks__/mendix.js"] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blame @stdagkalakis for triggering me on the RN. I would propose to frame the change as a fix, considering it is not really a new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the
Fixinstead ofFeature, and feel blamed