Skip to content

[WTF] Migrate The Repository to React 19 & React Native 0.78.2#163

Open
LEGIO-SEXTA-FERRATA wants to merge 9 commits intomasterfrom
wtf/react-19-native
Open

[WTF] Migrate The Repository to React 19 & React Native 0.78.2#163
LEGIO-SEXTA-FERRATA wants to merge 9 commits intomasterfrom
wtf/react-19-native

Conversation

@LEGIO-SEXTA-FERRATA
Copy link
Contributor

@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA commented Feb 17, 2026

This is no longer a test PR but is supposed to replace this.

"noUnusedLocals": true,
"noUnusedParameters": true,
"jsx": "react",
"jsxFactory": "createElement",
Copy link
Collaborator

@weirdwater weirdwater Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As demonstrated by the CI test, changing the JSX factory will require a lot of code changes to fix TS errors in (existing) widget code. If it is really necessary to move forward we may need to provide a codemod or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the dilemma now:
I switched the "jsx" config to "react-jsx" which fixed the build errors but then you cannot configure a jsxFactory. 🥲 Which makes the linter complain about the unused declaration in import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we still have to have the createElement import for a successful build.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to revisit the eslint rules to fix that.

Copy link
Collaborator

@weirdwater weirdwater Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, we need to change the following in the eslint base configs:

{
    "settings": {
        "react": {
            "pragma": "React"
        }
    },
    "rules": {
        /* These need to be modified to just this */
        "no-unused-vars": "warn",
        "@typescript-eslint/no-unused-vars": "warn",
        
        /* This needs to be added */
        "react/react-in-jsx-scope": "off",
    }
}

Explicit React imports for JSX is no longer necessary.

@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 6 times, most recently from b96d27b to ac0c413 Compare February 25, 2026 13:42
@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA changed the title [WTF] TEST [WTF] Migrate The Repository to React 19 & React Native 0.78.2 Feb 25, 2026
Comment on lines +17 to +22
// ["web", "full", "ts", "8.0"],
// ["native", "full", "ts", "8.6"],
// ["web", "full", "ts", "8.6"],
// ["web", "full", "js", "8.7"],
// ["web", "full", "ts", "8.9"],
// ["native", "full", "ts", "8.9"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is forgotten.

@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 2 times, most recently from 002e3b7 to 194afb2 Compare February 25, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants