[WC-3485]: fix(app-events-web): remove unexpected spacing caused by widget styles#2306
Open
r0b1n wants to merge 1 commit into
Open
[WC-3485]: fix(app-events-web): remove unexpected spacing caused by widget styles#2306r0b1n wants to merge 1 commit into
r0b1n wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
The widget-events class had flex-grow and positioning styles that caused unwanted spacing in flex container layouts at runtime. Since the widget renders no visible content, it should not occupy any space.
f72e046 to
6b2b1eb
Compare
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): All CI checks were not retrievable (permission restricted), but the change is purely a CSS/CHANGELOG edit with no logic or test impact. Positives
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widget-eventsclass hadflex-grow: 1,position: relative, andtransitionstyles that caused the widget div to occupy space in flex layouts at runtimedisplay: none)display: noneTest plan