Skip to content

Remove CsvAsTable#27

Draft
passalaqua wants to merge 8 commits into
masterfrom
dat/remove-csvastable
Draft

Remove CsvAsTable#27
passalaqua wants to merge 8 commits into
masterfrom
dat/remove-csvastable

Conversation

@passalaqua

Copy link
Copy Markdown
Contributor

Remove the dependency on CsvAsTable widget. Instead, use a different java action to create a markdown table from the result.

This change also removes the dependency on community commons.

…AsTable widget dependencies and re-wire the ACT_ExecuteOQL microflow to use the new java action to retrieve data as markdown; replace CsvAsTable with the markdown viewer in the OQL view demo page

Also renamed the CSV attribute of the Query NPE with Result, reflecting it no longer contains a CSV
Skip creating a FileDocument, do not accept DataSet, consider a markdown table as just a fancy CSV with | as separator (plus start end end characters on each line and a header separator).
@passalaqua

Copy link
Copy Markdown
Contributor Author

Once the functional changes of this PR are reviewed, I'll add a release note.

This ensures the same conditional viz. is applied to both the existing label and the result.
Comment thread javasource/oql/actions/ExportOQLToMarkdown.java Outdated
Comment thread OQLModule.mpr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants