Skip to content

[MOO-2278] - Refactor react-native patch #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MxKevinBeqo wants to merge 5 commits into
base: master
Choose a base branch
from
+414 −1,443
Open

[MOO-2278] - Refactor react-native patch #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55c2036
chore: cleanup react-native redundant patches; update rn patch versio…
MxKevinBeqo May 7, 2026
3e0db45
feat: toggle on react-native prebuilt binaries
MxKevinBeqo May 8, 2026
0e59112
chore: remove leftover react-native patch
MxKevinBeqo Jun 8, 2026
a7ed5ff
chore: update Podfile.lock and .pbxproj
MxKevinBeqo Jun 8, 2026
a31cdd7
fix: bring back the warning suppression for react-native js-only side
MxKevinBeqo Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ end
# Explicitly enable new architecture
ENV['RCT_NEW_ARCH_ENABLED'] = '1'

# Build React Native from source so patch-package changes to native RN code are compiled.
ENV['RCT_USE_PREBUILT_RNCORE'] = '0'
ENV['RCT_USE_RN_DEP'] = '0'
# When '0' = Build React Native from source so patch-package changes to native RN code are compiled (if any exist).
ENV['RCT_USE_PREBUILT_RNCORE'] = '1'
ENV['RCT_USE_RN_DEP'] = '1'

# The JS bundle is compiled compiled using a different version than the prebuilt Hermes engine embedded in the native binary, causing a runtime crash.
ENV['RCT_HERMES_V1_ENABLED'] = '0'
Expand Down Expand Up @@ -103,18 +103,6 @@ post_install do |installer|
# :ccache_enabled => true
)

installer.pods_project.targets.each do |target|
if target.name == 'fmt'
target.build_configurations.each do |config|
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << 'FMT_USE_CONSTEXPR=0'
config.build_settings['OTHER_CPLUSPLUSFLAGS'] ||= ['$(inherited)']
config.build_settings['OTHER_CPLUSPLUSFLAGS'] << '-Wno-invalid-constexpr'
config.build_settings['CLANG_CXX_LANGUAGE_STANDARD'] = 'c++23'
end
end
end

installer.pods_project.build_configurations.each do |config|
config.build_settings['OTHER_LDFLAGS'] ||= ['$(inherited)']
if config.name == "Debug"
Expand Down
Loading
Loading