Display a Donorbox link if the iframe is blocked#137
Merged
bdaehlie merged 1 commit intomemorysafety:mainfrom Mar 5, 2026
Merged
Display a Donorbox link if the iframe is blocked#137bdaehlie merged 1 commit intomemorysafety:mainfrom
bdaehlie merged 1 commit intomemorysafety:mainfrom
Conversation
This is similar to letsencrypt/website#2155 but since MemorySafety only hosts an iframe for matching, we do the matching here. This feels like it's not a great link, but the non-`embed` URL is a 404, so I don't know a better link to use.
✅ Deploy Preview for prossimo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jcjones
added a commit
to jcjones/abetterinternet-website
that referenced
this pull request
Feb 23, 2026
This a combination of letsencrypt/website#2155 and memorysafety/website#137 , with both a normal DonorBox link and two instances of the "Check Company Matching..." buttons.
Contributor
Author
|
divergentdave
approved these changes
Mar 4, 2026
divergentdave
left a comment
divergentdave
left a comment
There was a problem hiding this comment.
This iframe isn't caught by the original filter list we were looking at, but I added a custom filter rule and confirmed the fallback works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to letsencrypt/website#2155 but since MemorySafety only
hosts an iframe for matching, we do the matching here. This feels like it's not a great link,
but the non-
embedURL is a 404, so I don't know a better link to use.