Use 'GeoIP'/'GeoLite' branding in documentation#403
Open
oschwald wants to merge 6 commits into
Open
Conversation
MaxMind no longer ships the legacy products, so refer to the products as 'GeoIP' and 'GeoLite' rather than 'GeoIP2'/'GeoLite2' in prose. Technical identifiers (the geoip2 module, class names, filenames, edition IDs, hostnames, URLs) are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates references from "GeoIP2" and "GeoLite2" to "GeoIP" and "GeoLite" across documentation, configuration, and docstrings. A review comment correctly identifies a pre-existing typo ("th" instead of "the") in the module docstring of src/geoip2/models.py and provides a suggestion to fix it.
| @@ -1,4 +1,4 @@ | |||
| """The models for response from th GeoIP2 web service and databases. | |||
| """The models for response from th GeoIP web service and databases. | |||
There was a problem hiding this comment.
There is a typo in the module docstring: th should be corrected to the.
Suggested change
| """The models for response from th GeoIP web service and databases. | |
| """The models for response from the GeoIP web service and databases. |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a mise.toml/mise.lock pinning the language toolchain so local development and validation match CI, consistent with our other client libraries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
horgh
requested changes
May 29, 2026
| @@ -0,0 +1,37 @@ | |||
| # @generated - this file is auto-generated by `mise lock` https://mise.jdx.dev/dev-tools/mise-lock.html | |||
Contributor
There was a problem hiding this comment.
I think we might need this to be regenerated. I got some errors and running mise install updated it.
| .. deprecated:: 2.2.0 | ||
| Use our `GeoIP2 Anonymous IP database | ||
| Use our `GeoIP Anonymous IP database | ||
| <https://www.maxmind.com/en/geoip2-anonymous-ip-database GeoIP2>`_ |
Contributor
There was a problem hiding this comment.
From Claude, seems right:
- Bug — src/geoip2/records.py:~550: rST link text was renamed to "GeoIP Anonymous IP database" but the trailing literal " GeoIP2" inside the URL/title segment was not updated
(also pre-existing malformed rST: missing > between URL and title).
Remove a stray token inside the rST link target so the deprecation notice resolves to the GeoIP Anonymous IP database page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The initial lock was written while the GitHub API was rate-limited, so the uv tool had no per-platform checksums and 'mise install --locked' failed. Regenerated so every platform is pinned. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates prose/documentation to refer to the products as "GeoIP"/"GeoLite" instead of "GeoIP2"/"GeoLite2". Technical identifiers (the geoip2 module, class names, .mmdb filenames, edition IDs, the geolite.info hostname, URLs) are unchanged.
🤖 Generated with Claude Code