Skip to content

Migrate Jest to vitest #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mm-kevcenteno wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Migrate Jest to vitest #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f844efc
Migrate unit tests from Jest to Vitest
kevcenteno Jul 17, 2026
71db793
Restore 100% coverage under the v8 provider
kevcenteno Jul 17, 2026
7a93731
Migrate e2e tests from Jest to Vitest
kevcenteno Jul 17, 2026
da07448
Type-check spec files in lint
kevcenteno Jul 17, 2026
4fefca1
Update CLAUDE.md for Vitest
kevcenteno Jul 17, 2026
b93623e
Restore strict instanceof assertions for parse-error causes
kevcenteno Jul 17, 2026
134a08d
Use @preserve form for v8 coverage ignore hints
kevcenteno Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,19 @@ jobs:
with:
node-version: ${{ matrix.version }}
- run: npm ci
- run: npm test --coverage
- run: npm run test:coverage
- run: npm run build
- run: npm run build:docs
- run: npm link
- run: npm ci
working-directory: e2e/js
- run: npm link '@maxmind/geoip2-node'
working-directory: e2e/js
- run: npx jest
- run: npx vitest run
working-directory: e2e/js
env:
NODE_OPTIONS: --experimental-vm-modules
- run: npm ci
working-directory: e2e/ts
- run: npm link '@maxmind/geoip2-node'
working-directory: e2e/ts
- run: npx jest
- run: npx vitest run
working-directory: e2e/ts
env:
NODE_OPTIONS: --experimental-vm-modules
7 changes: 5 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The library provides both web service clients and database readers that return s
- TypeScript with strict type checking
- Node.js 22+ (targets active LTS versions)
- maxmind (node-maxmind) for MMDB database reading
- Jest for testing
- Vitest for testing
- ESLint + Prettier for code quality
- TypeDoc for API documentation

Expand Down Expand Up @@ -123,11 +123,14 @@ npm install
# Run all tests
npm test

# Run tests with coverage (thresholds enforced)
npm run test:coverage

# Run tests in watch mode
npm run test:watch

# Run specific test file
npx jest src/readerModel.spec.ts
npx vitest run src/readerModel.spec.ts
```

### Linting and Building
Expand Down
1 change: 1 addition & 0 deletions e2e/js/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { describe, expect, it } from 'vitest';
import { WebServiceClient, Reader } from '@maxmind/geoip2-node';

describe('WebServiceClient', () => {
Expand Down
Loading