ShortestPath extension to getting custom info chain implemented#39
Open
ridicoulous wants to merge 1 commit intomatiii:masterfrom
Open
ShortestPath extension to getting custom info chain implemented#39ridicoulous wants to merge 1 commit intomatiii:masterfrom
ridicoulous wants to merge 1 commit intomatiii:masterfrom
Conversation
matiii
reviewed
Jan 10, 2019
| var currentNode = iterator.Current; | ||
| while (iterator.MoveNext()) | ||
| { | ||
| yield return GetFirstEdgeCustom(graph, currentNode, iterator.Current); |
Owner
There was a problem hiding this comment.
What if between two nodes will bo more than one edge ?
Author
There was a problem hiding this comment.
Hello. Mea culpa. I implemented this method to work with my custom aggregated info (GROUP BY from,to) so I have only one groupped edge between nodes in path. I will take a look what will be good realization of this veriant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38 primitive implementation. I think, may be useful to improve this extension by adding to result info about linked nodes, but at this iteration, I think it's not necessary. @matiii what you think about this?