Skip to content

Ensure that PCT is installed and licenesed before checking if a pool … #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanpo merged 1 commit into from
Mar 31, 2026
Merged

Ensure that PCT is installed and licenesed before checking if a pool … #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
push:
branches:
- main
- mbt-plugin
- pct-unavailable-fix
env:
MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }}
jobs:
Expand Down
10 changes: 6 additions & 4 deletions instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ function runBuild(plugin, pluginData)
%
% Imperfect detection of parallel builds but
% the impact of a false positive is very low
p = gcp("nocreate");
if ~isempty(p)
warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ...
"Tasks executed on parallel workers do not emit telemetry data.");
if matlab.internal.parallel.isPCTInstalled && matlab.internal.parallel.isPCTLicensed
p = gcp("nocreate");
if ~isempty(p)
warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ...
"Tasks executed on parallel workers do not emit telemetry data.");
end
end

% Configure by attaching to span if passed in via environment
Expand Down
Loading