feat(dockview-core): pinnable overlay panels for edge groups (#1283)#1295
Open
0211Abhay wants to merge 1 commit into
Open
feat(dockview-core): pinnable overlay panels for edge groups (#1283)#12950211Abhay wants to merge 1 commit into
0211Abhay wants to merge 1 commit into
Conversation
…1283) Adds a pinnable/auto-hide overlay mode for edge groups, matching the Visual Studio tool-window pattern (closes mathuo#1283, relates to mathuo#664). Pinned (default): edge groups push the layout when expanded — existing behaviour is unchanged. Unpinned: the group collapses to its tab strip only in the layout. Clicking a tab opens the panel as an absolutely-positioned overlay over the content area; clicking outside dismisses it. - EdgeGroupOptions.pinned?: boolean — opt-in at construction time - DockviewGroupPanelApi: setPinned() / isPinned() / onDidPinnedChange - ShellManager: setEdgeGroupPinned / isEdgeGroupPinned with full overlay lifecycle (_showOverlay / _hideOverlay) - Overlay removes dv-edge-collapsed on show and restores it on hide, fixing invisible content and pointer-event steal in the collapsed slot - Shell element: overflow:clip + isolation:isolate for stacking context - dv-content-container: overflow:hidden on edge groups prevents bleed - pinned state serialised in toJSON and restored in fromJSON - DockviewGroupPanelPinnedChangeEvent exported from index.ts - 100 new tests across dockviewShell.spec.ts and dockviewGroupPanelApi.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1283, relates to #664
Edge groups could be collapsed to their tab strip but had no way to expand as a floating overlay without pushing the layout.
This PR adds a pinnable/auto-hide mode for edge groups, matching the Visual Studio tool-window pattern.
Pinned (default): edge groups push the layout when expanded — existing behaviour is unchanged.
Unpinned: the group collapses to its tab strip only in the layout. Clicking a tab opens the panel as an absolutely-positioned overlay over the content area. Clicking outside dismisses it.
Screen.Recording.2026-05-22.021332.mp4
Type of change
Affected packages
dockview-coredockview(vanilla JS)dockview-reactdockview-vuedockview-angulardocsHow to test
yarn jest --selectProjects dockview-coreChecklist
yarn lint:fixpassesyarn formatpassesnpm run genhas been run and generated files are up to dateyarn testpasses