Skip to content

Fixes 1948#1951

Open
affeldt-aist wants to merge 3 commits intomath-comp:masterfrom
affeldt-aist:fixes_1948
Open

Fixes 1948#1951
affeldt-aist wants to merge 3 commits intomath-comp:masterfrom
affeldt-aist:fixes_1948

Conversation

@affeldt-aist
Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist commented Apr 24, 2026

Motivation for this change

fixes #1948

fixes #1945

closes #1950

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist
Copy link
Copy Markdown
Member Author

affeldt-aist commented Apr 25, 2026

Since this PR is just about replacing a bunch of Local Lemma to Let, which is good.

It reveals in particular that the extension measure theorem was actually relying on a local lemma and a few type casts; I think that the proper way to do that with HB is to introduce an identifier.
This PR also implements this fix.

@affeldt-aist affeldt-aist requested a review from CohenCyril April 25, 2026 03:54
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Apr 25, 2026
@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

should be Let typo

1 participant