independence, expectation of product#1391
Open
affeldt-aist wants to merge 18 commits intomath-comp:masterfrom
Open
independence, expectation of product#1391affeldt-aist wants to merge 18 commits intomath-comp:masterfrom
affeldt-aist wants to merge 18 commits intomath-comp:masterfrom
Conversation
affeldt-aist
added
the
enhancement ✨
Member
Author
|
Maybe it is better to rename |
affeldt-aist
force-pushed
the
probability_20241105
branch
2 times, most recently
from
0895272 to
bc59196
Compare
2 tasks
affeldt-aist
force-pushed
the
probability_20241105
branch
2 times, most recently
from
538b914 to
d32696d
Compare
t6s
reviewed
Dec 3, 2024
Member
t6s
left a comment
t6s
left a comment
There was a problem hiding this comment.
I have reviewed lines 0 -- 878 and quickly looked through 879-.
The latter things need some cleaning.
affeldt-aist
force-pushed
the
probability_20241105
branch
5 times, most recently
from
0ab14bf to
a1eb371
Compare
affeldt-aist
force-pushed
the
probability_20241105
branch
2 times, most recently
from
aabd8b3 to
a811b46
Compare
affeldt-aist
force-pushed
the
probability_20241105
branch
4 times, most recently
from
a93338c to
1c8f2b0
Compare
affeldt-aist
force-pushed
the
probability_20241105
branch
from
a5018df to
f11f96f
Compare
Member
Author
|
(I just made a rebase on master, hence the push force) |
affeldt-aist
force-pushed
the
probability_20241105
branch
from
f11f96f to
59e30be
Compare
2 tasks
2 tasks
affeldt-aist
force-pushed
the
probability_20241105
branch
from
59e30be to
7fc4df9
Compare
affeldt-aist
force-pushed
the
probability_20241105
branch
from
61f649e to
799861f
Compare
- fix changelog - mv defs to appropriate files
affeldt-aist
force-pushed
the
probability_20241105
branch
from
799861f to
bb5cbfe
Compare
Member
Author
|
@t6s I have rebased, cleaned up the proofs, since a few things have been introduced into master since, I could eliminate duplicates. Several files are touched but that is because this PR led us to simplify lemmas about What about we merge? (as a step towards completion of issue 1808) |
Member
Author
|
(CI green at last) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers