[MaterialButton] apply layout direction to button#4944
Closed
ShaiAlkoby wants to merge 1 commit intomaterial-components:masterfrom
Closed
[MaterialButton] apply layout direction to button#4944ShaiAlkoby wants to merge 1 commit intomaterial-components:masterfrom
ShaiAlkoby wants to merge 1 commit intomaterial-components:masterfrom
Conversation
Contributor
|
Hi! I believe our buttons and icons in buttons are working correctly. Looking at, #4945, I can use the button you suggest and it will be mirrored properly when switching between LTR and RTL. See the top button with the "step over" icon in the screenshots:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applying layout direction to the button icon to support RTL languages
Thanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationContributing
has more information and tips for a great pull request.