Fix pybind11 type and signature handling issues #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix type mismatches and invalid identifier issues in the Python bindings that could cause import or runtime errors. - Convert PyLong_AsLongLong to PyLong_AsLong to match value_holder type - Replace invalid argument name with space (layer idx -> layer_idx) - Add missing pybind11/stl.h include for std::vector return types Changes: - src/mapnik_value_converter.hpp: Use correct integer conversion - src/mapnik_map.cpp: Fix py::arg identifier with invalid space character - src/mapnik_font_engine.cpp: Include STL bindings for vector types
artemp
approved these changes
Feb 10, 2026
Member
artemp
left a comment
artemp
left a comment
There was a problem hiding this comment.
I'm curious about #include <pybind11/stl.h> in src/mapnik_font_engine.cpp
Perhaps, related to toolchain used. Which platform/compiler are you using?
Member
I added NOTE: Better approach would be to add a simple traits object to handle correct type conversions at compile time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
These changes fix type mismatches and invalid identifier issues in the Python bindings that could cause import or runtime errors. Fixes #297
addressed issues
PyLong_AsLongLongtoPyLong_AsLongto matchvalue_holdertypelayer idxtolayer_idx)pybind11/stl.hinclude forstd::vectorreturn typeschanges
src/mapnik_value_converter.hpp: Use correct integer conversionsrc/mapnik_map.cpp: Fixpy::argidentifier with invalid space charactersrc/mapnik_font_engine.cpp: Include STL bindings for vector type