Flatten polygon rings into Float64Arrays#122
Open
PontusHorn wants to merge 1 commit intomapbox:masterfrom
Open
Flatten polygon rings into Float64Arrays#122PontusHorn wants to merge 1 commit intomapbox:masterfrom
PontusHorn wants to merge 1 commit intomapbox:masterfrom
Conversation
Pre-flattens polygon rings into contiguous Float64Arrays to speed up geometric computations and reduce iteration overhead. Improves performance of distance and centroid calculations by avoiding nested array structures. Benchmarks show performance improvements across many different kinds of polygons, especially with complex polygons (40%+ for the "water1" and "water2" fixtures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flattens polygon rings into contiguous Float64Arrays to speed up geometric computations and reduce iteration overhead. Improves performance of distance and centroid calculations by avoiding nested array structures.
Benchmarks show performance improvements across many different kinds of polygons, especially with complex polygons (40%+ for the "water1" and "water2" fixtures).
Not sure what level of browser support this project has, but Float64Array has been available across browsers since 2015 so it's very widespread.
These are my benchmark results from this branch:
Versus master:
Benchmark file:
benchmark.js