Skip to content

fixed issue #50 when native scrollbars are visible when zoomed out. p…#89

Open
ghost wants to merge 1 commit intomalte-wessel:masterfrom
IvanKalinin:fix--native-scrollbars-on-zoom
Open

fixed issue #50 when native scrollbars are visible when zoomed out. p…#89
ghost wants to merge 1 commit intomalte-wessel:masterfrom
IvanKalinin:fix--native-scrollbars-on-zoom

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 4, 2016

…revented infinite loop in the colored example
@malte-wessel
Copy link
Copy Markdown
Owner

checking scrollbar width on every handleWindowResize would lead to a huge performance drop and since this is an edge case I'm not really happy with this approach

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 5, 2016

Unfortunately there is no way to get 'zoom' event. Browser's zoom triggers resize event.
Window resizing is quite rare event and on resize user doesn't scroll anything, so it shouldn't have a drop performance affect

@Ponjimon
Copy link
Copy Markdown

I'm still having this issue. Would it make sense to throttle/debounce this to prevent a too huge performance drop?

@Colmea
Copy link
Copy Markdown

Colmea commented Apr 18, 2018

@malte-wessel I understand why you're not happy with this implementation, but window resize is still an issue with this package.

Do you think we could, at least, have a public method (this.refs.scrollbar.forceUpdate() ?) to force width recalculation ? This way the package doesn't update by default (no performance drop), but user still have a possibility to trigger recalculation by itself.

I could create a Merge Request if you like the idea

@sorenhoyer
Copy link
Copy Markdown

This is a problem for us as well. Is this library dead? :-)

@DeRoPega
Copy link
Copy Markdown

@sorenhoyer looks like it's dead) the problem exists for a long time and there are no solution for it((

@hoanglvbd
Copy link
Copy Markdown

You could use react-custom-scrollbars-2 will fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants