Fix broken DOI link and docstring typos#874
Merged
jonbrenas merged 4 commits intomalariagen:masterfrom Mar 6, 2026
Merged
Conversation
- README.md: add missing https:// prefix to DOI citation link (malariagen#857) - snp_frq.py: fix 'varaint' -> 'variant' (2 occurrences) - snp_frq.py: fix 'accross' -> 'across' (2 occurrences) - snp_frq.py: fix 'amino acide' -> 'amino acid' - snp_frq.py: fix 'allel,' -> 'allele,'
Collaborator
tristanpwdennis
left a comment
tristanpwdennis
left a comment
There was a problem hiding this comment.
Looks good to me, will merge soon unless anyone objects
Contributor
Author
@tristanpwdennis Thank you Sir!! |
jonbrenas
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #857
While looking through the codebase I noticed the DOI citation link in the README was missing its https:// prefix, which means it renders as a relative link instead of a clickable URL. Fixed that.
I also spotted a handful of typos in the snp_allele_frequencies and �a_allele_frequencies docstrings in snp_frq.py while I was in there:
Documentation-only changes, no behavior change.