[GIT-235] fix: remove unsupported styles from onboarding tour close button

[Rahulcheryala]

Description

Improves close button visibility on the onboarding tour modal by increasing its contrast against the modal background. Additionally removes shadow-md and hover:bg-surface-3 from the close button as they are not supported by the design system.

Picks up the fix contributed by @Marsssssssssssdsss in #9186.

Type of Change

• Code refactoring

Screenshots and Media (if applicable)

References

Closes #9186
GIT-235

Summary by CodeRabbit

• Style
  • Updated the onboarding tour’s close button styling for improved visual consistency.
  • Visual polish ensures the close control better matches surrounding interface elements and maintains existing layout and behavior.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9968b51-794d-419c-aae7-fcee53466f3d

📥 Commits

Reviewing files that changed from the base of the PR and between 3aeb663 and f508633.

📒 Files selected for processing (1)

• apps/web/ce/components/onboarding/tour/root.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/web/ce/components/onboarding/tour/root.tsx

---

📝 Walkthrough

Walkthrough

The close (“X”) button in the onboarding tour modal was given a background surface class (bg-surface-1) to improve its visual contrast against the header.

Changes

Onboarding Tour Close Button Styling

Layer / File(s)	Summary
Close button background contrast apps/web/ce/components/onboarding/tour/root.tsx	The close button's className is updated to include bg-surface-1, providing a visible background surface that stands out from the modal header.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped by the modal, a tiny surprise,
The close button now wears a soft, gentle guise.
Where once it was hidden against the blue,
A surface now makes it easy to view.
Hooray for small changes that brighten the cue!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title clearly indicates the main change: removing unsupported styles from onboarding tour close button, directly matching the code modification.
Description check	✅ Passed	PR description follows the template with all required sections completed: Description, Type of Change (Code refactoring), Screenshots, and References linking to #9186 and GIT-235.
Linked Issues check	✅ Passed	The PR addresses #9186's objective of improving close button contrast but removes unsupported design system styles (shadow-md, hover:bg-surface-3) while adding the supported bg-surface-1 background.
Out of Scope Changes check	✅ Passed	All changes are scoped to the single line modification in the close button's className as specified in the linked issue, with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/GIT-235-remove-unsupported-styles

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[makeplane]

Linked to Plane Work Item(s)

• [GIT-235] improve close button contrast on onboarding tour modal

This comment was auto-generated by Plane