refactor!: remove AAP; add boot_disk_size; bundle opencode config#2
Merged
refactor!: remove AAP; add boot_disk_size; bundle opencode config#2
Conversation
The Ansible Automation Platform integration (aap_organization, aap_inventory, aap_host, aap_job_template, aap_job) is removed along with its provider declaration. The companion variables (enable_aap, aap_org_name, aap_inventory_name, aap_job_template_name) are dropped, as are the now-orphaned private_ip_addr and proxyhost variables which were only consumed by the AAP host block. Adds a new boot_disk_size variable that sets the libvirt_volume.boot capacity in bytes, allowing callers to grow the boot disk beyond the source image's natural size (useful for Talos nocloud images that ship small). BREAKING CHANGE: Callers passing enable_aap, aap_*, private_ip_addr, or proxyhost arguments must remove them. Hosts requiring Ansible configuration should drive it from outside this module. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
xnoto
changed the title
The arc-dind runner pool depends on the in-cluster actions-runner-controller in kustomize-cluster, which is offline during the libvirt-host migration. Swap to GitHub-hosted ubuntu-latest runners so PRs can validate; revert to arc-dind once the new cluster is up.
The previous reference to ghcr.io/makeitworkcloud/runner:latest does not exist in the registry. The canonical image (built by the images repo and bundling pre-commit hooks) is published as ghcr.io/makeitworkcloud/tfroot-runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private_ip_addr/proxyhostvariables that only fed the AAP host block). Callers configuring VMs via Ansible should now drive it from outside this module (e.g. cloud-init).boot_disk_sizevariable that setslibvirt_volume.boot.capacityin bytes so callers can grow the boot disk beyond the source image's natural size — needed for Talos's small nocloud qcow2.Test plan
make testpassestfroot-libvirt) plans cleanly after AAP arguments are removed and the new k3s/talos modules are wired upMigration notes
Any caller passing the following arguments must drop them:
enable_aap,aap_org_name,aap_inventory_name,aap_job_template_name,private_ip_addr,proxyhost