Sending domains endpoints#104
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| # @return [CompanyInfo] Updated company information | ||
| # @!macro api_errors | ||
| # @raise [ArgumentError] If invalid options are provided | ||
| def update(sending_domain_id, options) |
There was a problem hiding this comment.
same question as before: shouldn’t it be upsert?
There was a problem hiding this comment.
I think we split the endpoint though
| account_id = 3229 | ||
| sending_domain_id = 1 | ||
| client = Mailtrap::Client.new(api_key: 'your-api-key') | ||
| company_info_api = Mailtrap::CompanyInfoAPI.new(account_id, client) |
There was a problem hiding this comment.
sometimes its {endpoint}_api and sometimes just {endpoint} name of the variable, maybe worth to have single style.
There was a problem hiding this comment.
_api seems more correct. Because if you store result of create into a var, then what would be the name?
| # @return [CompanyInfo] Updated company information | ||
| # @!macro api_errors | ||
| # @raise [ArgumentError] If invalid options are provided | ||
| def update(sending_domain_id, options) |
There was a problem hiding this comment.
I think we split the endpoint though
3 participants
Motivation
Changes