Skip to content

no-std: Use items from core where possible #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fogti wants to merge 2 commits into
base: master
Choose a base branch
from
Open

no-std: Use items from core where possible #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
005e478
feat(errors): Use Error trait from core crate
fogti Feb 18, 2026
cce6cd3
chore: use core::str::FromStr everywhere
fogti Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bit/adjusted/rocket_traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr;
use core::str::FromStr;

use rocket::{
form::{self, FromFormField, ValueField},
Expand Down
2 changes: 1 addition & 1 deletion src/bit/rocket_traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr;
use core::str::FromStr;

use rocket::{
form::{self, FromFormField, ValueField},
Expand Down
2 changes: 1 addition & 1 deletion src/byte/adjusted/rocket_traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr;
use core::str::FromStr;

use rocket::{
form::{self, FromFormField, ValueField},
Expand Down
2 changes: 1 addition & 1 deletion src/byte/rocket_traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr;
use core::str::FromStr;

use rocket::{
form::{self, FromFormField, ValueField},
Expand Down
11 changes: 4 additions & 7 deletions src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
use core::fmt::{self, Display, Formatter};
#[cfg(any(feature = "byte", feature = "bit"))]
pub use core::num::TryFromIntError;
#[cfg(feature = "std")]
use std::error::Error;
use core::{
error::Error,
fmt::{self, Display, Formatter},
};

#[cfg(any(feature = "byte", feature = "bit"))]
use rust_decimal::Decimal;
Expand All @@ -21,7 +22,6 @@ impl Display for ExceededBoundsError {
}

#[cfg(any(feature = "byte", feature = "bit"))]
#[cfg(feature = "std")]
impl Error for ExceededBoundsError {}

#[cfg(any(feature = "byte", feature = "bit"))]
Expand Down Expand Up @@ -50,7 +50,6 @@ impl Display for ValueParseError {
}

#[cfg(any(feature = "byte", feature = "bit"))]
#[cfg(feature = "std")]
impl Error for ValueParseError {}

/// The error type returned when parsing units.
Expand Down Expand Up @@ -111,7 +110,6 @@ impl Display for UnitParseError {
}
}

#[cfg(feature = "std")]
impl Error for UnitParseError {}

#[cfg(any(feature = "byte", feature = "bit"))]
Expand Down Expand Up @@ -150,5 +148,4 @@ impl Display for ParseError {
}

#[cfg(any(feature = "byte", feature = "bit"))]
#[cfg(feature = "std")]
impl Error for ParseError {}
2 changes: 1 addition & 1 deletion src/unit/rocket_traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::str::FromStr;
use core::str::FromStr;

use rocket::{
form::{self, FromFormField, ValueField},
Expand Down