Little fixes (vibe coded)#139
Open
LotusRPG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Parent version: 1.1.1-R2.1-SNAPSHOT → 1.1.1-R0.17-SNAPSHOT
NexoMC dependency: 1.23 → 1.21.0
Removed codex-nms-v1_16_5 module from POM
2. NMS Hover Event Fixes (Multiple Versions)
v1.21.1: Removed unused imports (NamespacedKey, Registry, Locale) and the entire getAttribute() method
v1.21.7, v1.21.10, v1.21.11: Improved regex patterns for JSON number formatting:
Simplified boolean fix (keep 0b → false, 1b → true)
Better handling of floats/doubles with f/d suffixes using unified regex patterns
Added clarifying comments and debug statements
codex-plugin/IUserManager.java: Changed HashMap<>() → ConcurrentHashMap<>() for the activeUsers field to prevent concurrent modification issues
4. Code Cleanup
Removed unused imports and empty lines in NMS implementations
Added inline documentation for regex fixes