Skip to content

feat: add adjust sample apps and CI example builds#723

Merged
denischilik merged 5 commits into
workstation/6.0-Releasefrom
feat/android-kit-sample-apps
Jun 23, 2026
Merged

feat: add adjust sample apps and CI example builds#723
denischilik merged 5 commits into
workstation/6.0-Releasefrom
feat/android-kit-sample-apps

Conversation

@denischilik

Copy link
Copy Markdown

Summary

  • Add Kotlin and Java sample apps for adjust-5 under kits/adjust/adjust-5/example/, matching the iOS kit example pattern.
  • Introduce settings-kit-examples.gradle so example modules are built only via CI and stay out of settings-kits.gradle and kit settings.gradle.kts.
  • Add kits/matrix.json and build-kits.yml to run kit unit tests and assemble both sample apps in PR CI.

Test plan

  • ./gradlew -c settings-kit-examples.gradle -Pmparticle.kit.mparticleFromMavenLocalOnly=true ":kits:android-adjust:adjust-5:example-kotlin:assembleDebug"
  • ./gradlew -c settings-kit-examples.gradle -Pmparticle.kit.mparticleFromMavenLocalOnly=true ":kits:android-adjust:adjust-5:example-java:assembleDebug"
  • Verify build-kits workflow passes on PR
  • Confirm settings-kits.gradle builds remain unchanged

Introduce Kotlin/Java sample apps for adjust-5 and wire a CI-only settings
file so example modules stay isolated from kit settings and settings-kits.gradle.
@denischilik denischilik requested a review from a team as a code owner June 22, 2026 20:23
@cursor

cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to sample apps and CI wiring; no production kit or core SDK behavior is modified in this diff.

Overview
Adds matrix-driven kit CI via build-kits.yml and wires it into the PR workflow (including Dependabot automerge gating). The workflow loads kits/matrix.json, publishes the core SDK to Maven Local, runs per-kit testRelease, and optionally assembles Kotlin/Java example apps through settings-kit-examples.gradle.

Introduces an Adjust 5 Kotlin sample app under kits/adjust/adjust-5/example/example-kotlin (minimal MParticle bootstrap in ExampleApplication, standard launcher UI). Example modules stay out of settings-kits.gradle; only settings-kit-examples.gradle includes them for CI builds.

Reviewed by Cursor Bugbot for commit 38b8cba. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 45d9197. Configure here.

Comment thread settings-kit-examples.gradle Outdated
@denischilik denischilik changed the title feat(kits): add adjust sample apps and CI example builds feat: add adjust sample apps and CI example builds Jun 22, 2026
Fix semgrep blocking findings for mutable GitHub Actions tag references.
Use explicit android- prefixed includes and projectDir mappings so kit
examples, dependencies, and CI matrix tasks resolve the same modules.
Keep kit registration unchanged and rely on the existing android- rename
so example modules and CI matrix paths continue to resolve correctly.

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Keep only the Kotlin example and drop Java example wiring from CI matrix
and kit example settings.
@denischilik denischilik merged commit a45f0af into workstation/6.0-Release Jun 23, 2026
43 of 46 checks passed
@denischilik denischilik deleted the feat/android-kit-sample-apps branch June 23, 2026 20:15
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants