Merged
Conversation
…king - Extract all domain types/enums from spec into src/types.ts (SRP) - Slim spec file to HybridObject bridge contract only - Replace InAppBrowser static class with named function exports (tree shaking) - Use getHybridObjectConstructor from Nitro 0.35 — removes hand-rolled caching - Remove mapOptions alias (DRY) - Fix utils/options.ts: re-import from ../types, remove @ts-expect-error casts - Narrow useInAppBrowser hook: only open/openAuth use runSafely (SRP) - Clean index.ts: no class mutation, explicit export type separations - Update README for v3 named exports API + add migration guide BREAKING CHANGE: InAppBrowser.method() replaced by named imports
iOS: - Remove DispatchQueue.main.sync deadlock risk — mark nitroTopMostViewController @mainactor - Drop SFAuthenticationSession (iOS 11 dead code) — ASWebAuthenticationSession only - Remove all #available(iOS 13.0, *) guards (unreachable at iOS 16+ deployment target) - Simplify AuthSessionManager to single session property, 2-line cancel() Android: - Fix self-referential applicationContext getter — single NitroModules.applicationContext call - Lift Chrome-only Custom Tabs restriction — any provider (Samsung, Firefox, Brave, Edge) now works - Replace private reflection for high-contrast detection with public AccessibilityManager API (API 31+) - Fix deprecated getPackageInfo(name, 0) — use PackageInfoCompat with Long flags - Document close()/closeAuth() no-ops as intentional
…ects flag refactor: Enhance native.ts with lazy initialization for hybrid object and improve URL validation refactor: Optimize useInAppBrowser hook for better loading and error handling fix: Update index.ts to export types correctly and streamline imports chore: Refactor types.ts for consistency and clarity in type definitions refactor: Improve options sanitization in utils/options.ts for cleaner code fix: Enhance URL validation logic in utils/url.ts for better error handling chore: Update yarn.lock to include biomejs for improved linting and formatting Co-authored-by: Copilot <copilot@github.com>
Add a top-level biome.json for formatting/linting and remove example/biome.json; update .gitignore to ignore stray TS/TSX/JS build outputs. Reformat and clean up example sources (App.tsx, index.js, babel.config.js) — style tweaks, import/path normalization, remove extra empty tokens, and refactor example logging to use ids with useRef. Clean up Xcode project build phase entries (remove empty input/output paths). Apply minor code/style and config updates across source and tooling files, and update example iOS pod versions in Podfile.lock.
Switch JNI_OnLoad to call registerNatives instead of initialize. Replace PackageInfoCompat usage with Context.getPackageInfo and add explicit NameNotFoundException handling (plus a deprecation suppression) in CustomTabsPackageHelper. Add a reflection-based isHighTextContrastEnabledSafe helper in DynamicColorResolver to safely call the hidden AccessibilityManager API and fall back to false when unavailable. These changes improve JNI registration consistency and make Android package/accessibility checks more robust across API levels.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the library’s public JS API (moving from a static InAppBrowser class to named exports), refactors type definitions and option/url normalization, and updates the Android/iOS implementations plus project tooling/config to improve compatibility and maintainability.
Changes:
- Replaced the
InAppBrowserstatic class with named exports via a new native wrapper (src/core/native.ts) and updated types to live insrc/types.ts. - Refactored options/url validation helpers and the React hook to align with the new API surface.
- Updated Android/iOS implementations and refreshed repo tooling/config (Biome, RN/Nitro versions, Gradle wrapper, example app configs).
Reviewed changes
Copilot reviewed 38 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adjusted TS compiler settings (notably noEmit and rootDir). |
| src/utils/url.ts | Replaced normalizeUrl with validateUrl and centralized scheme checks. |
| src/utils/options.ts | Refactored option normalization to a per-key normalizer map and shared trimming helpers. |
| src/types.ts | Introduced a central TS types/constants module for the public API surface. |
| src/specs/inappbrowser-nitro.nitro.ts | Slimmed Nitro spec to import shared types from src/types.ts. |
| src/index.ts | Switched to named exports from ./core/native and re-exported types/constants. |
| src/hooks/useInAppBrowser.ts | Updated hook to call named exports and return a memoized API object. |
| src/core/native.ts | Added lazy JSI hybrid object accessor and the new functional API (open, openAuth, etc.). |
| src/core/InAppBrowser.ts | Removed the previous static-class wrapper. |
| scripts/remove-source-maps.cjs | Updated Node imports to node: built-ins. |
| post-script.js | Formatting cleanup and switched to node: built-ins. |
| package.json | Added exports, Biome scripts, bumped dependencies, and updated Bob build targets and types paths. |
| nitro.json | Updated Nitro autolinking schema/config layout and formatting. |
| ios/UIApplication+TopMost.swift | Replaced manual main-thread sync with @MainActor isolation. |
| ios/SafariPresenter.swift | Formatting plus simplifications around style mapping/availability checks. |
| ios/AuthSessionManager.swift | Simplified to ASWebAuthenticationSession, retained presentation provider, and simplified cancel logic. |
| example/tsconfig.json | Added ignoreDeprecations and formatting cleanup. |
| example/react-native.config.js | Updated node: imports and reformatted config. |
| example/package.json | Updated RN-related deps/tooling; switched linting to Biome; updated Node engine requirement. |
| example/metro.config.js | Reformatted and switched to node: imports. |
| example/jest.config.js | Formatting cleanup. |
| example/ios/InAppBrowserNitroExample/Info.plist | Reorganized keys and restricted supported orientations to portrait. |
| example/ios/InAppBrowserNitroExample/Images.xcassets/Contents.json | JSON formatting cleanup. |
| example/ios/InAppBrowserNitroExample/Images.xcassets/AppIcon.appiconset/Contents.json | JSON formatting cleanup. |
| example/ios/InAppBrowserNitroExample.xcodeproj/project.pbxproj | Updated build settings and flags for the example project. |
| example/index.js | Formatting cleanup. |
| example/babel.config.js | Updated node: imports and formatting cleanup. |
| example/android/gradlew.bat | Modified wrapper invocation parameters. |
| example/android/gradlew | Modified wrapper invocation parameters. |
| example/android/gradle/wrapper/gradle-wrapper.properties | Bumped Gradle distribution URL. |
| example/android/gradle/wrapper/gradle-wrapper.jar | Added/updated Gradle wrapper JAR. |
| example/android/app/build.gradle | Updated comments around debuggable variants. |
| example/Gemfile.lock | Updated Ruby gem versions (notably minitest). |
| example/App.tsx | Updated to use named exports; improved logging and formatting/accessibility text layout. |
| example/.prettierrc.js | Removed Prettier config (tooling migrated to Biome). |
| example/.eslintrc.js | Removed ESLint config (tooling migrated to Biome). |
| biome.json | Added Biome formatter/linter configuration. |
| android/src/main/java/com/inappbrowsernitro/browser/DynamicColorResolver.kt | Improved high-contrast detection gating + safe reflection fallback. |
| android/src/main/java/com/inappbrowsernitro/browser/CustomTabsPackageHelper.kt | Expanded package-check error handling and added deprecation suppression. |
| android/src/main/java/com/inappbrowsernitro/HybridInappbrowserNitro.kt | Improved context handling and clarified close/closeAuth behavior. |
| android/src/main/cpp/cpp-adapter.cpp | Switched JNI init to fbjni::initialize and explicit native registration. |
| android/build.gradle | Added androidx.core:core dependency. |
| README.md | Updated docs/examples for named exports and moved wrapper reference to src/core/native.ts. |
| .gitignore | Ignored stray emitted JS/d.ts outputs under src/. |
| .github/FUNDING.yml | Added GitHub funding configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
66
to
69
| private final class AuthPresentationContextProvider: NSObject, ASWebAuthenticationPresentationContextProviding { | ||
| func presentationAnchor(for session: ASWebAuthenticationSession) -> ASPresentationAnchor { | ||
| UIApplication.shared.nitroTopMostViewController?.view.window ?? UIWindow() | ||
| } |
There was a problem hiding this comment.
UIApplication.nitroTopMostViewController is now @MainActor, but AuthPresentationContextProvider.presentationAnchor(for:) is not isolated to the main actor. Accessing the main-actor property from this synchronous, nonisolated method can fail strict concurrency checks. Mark AuthPresentationContextProvider (or at least presentationAnchor(for:)) as @MainActor, or use a main-actor hop that is compatible with the protocol requirements.
Comment on lines
+56
to
68
| const open = useCallback( | ||
| async (url: string, options?: InAppBrowserOptions) => { | ||
| setIsLoading(true) | ||
| setError(null) | ||
| try { | ||
| return await nativeOpen(url, options) | ||
| } catch (err) { | ||
| const next = toError(err) | ||
| setError(next) | ||
| throw next | ||
| } finally { | ||
| setIsLoading(false) | ||
| } |
There was a problem hiding this comment.
The hook now always calls setIsLoading(false) in finally, even if the component unmounts before nativeOpen/nativeOpenAuth resolves. This can trigger "state update on unmounted component" warnings in some React setups. Consider restoring the previous mounted-guard (e.g. useRef + cleanup) or using an abort/ignore pattern so async completions don't update state after unmount.
Comment on lines
8
to
12
| export const validateUrl = (candidate: string): string => { | ||
| const trimmed = candidate.trim() | ||
|
|
||
| if (!trimmed) { | ||
| throw new Error('URL must be a non-empty string.') |
There was a problem hiding this comment.
validateUrl assumes candidate is always a string and calls candidate.trim() directly. Because this is a public API boundary (called from JS), passing null/undefined/non-string values will now throw a TypeError instead of the intended, descriptive error. Consider validating typeof candidate === 'string' (or coercing safely) before trimming so callers get a consistent error message.
…nown and throw TypeError for non-string inputs - useInAppBrowser: guard setState calls behind mounted ref to avoid warnings after unmount - AuthPresentationContextProvider.presentationAnchor: mark @mainactor for strict concurrency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the codebase, focusing on modernizing the API, enhancing Android compatibility, improving accessibility support, and updating documentation and configuration files. The most important changes are summarized below.
API Refactor and Documentation Updates
InAppBrowserclass to named exports (open,openAuth,close,closeAuth,isAvailable) for better tree shaking and modern usage; updated all relevant documentation and example usages to reflect this change. [1] [2] [3] [4] [5]src/core/native.tsinstead ofsrc/core/InAppBrowser.ts.Android Platform Improvements
HybridInappbrowserNitro.ktfor more reliable activity resolution and ensured that the browser closes correctly by relying on user navigation, with explanatory comments. [1] [2] [3]CustomTabsPackageHelper.ktand added suppression for deprecated API usage.DynamicColorResolver.kt, using reflection only on supported Android versions and providing a safe fallback. [1] [2]Dependency and Build System Updates
androidx.core:coreas a dependency inandroid/build.gradleto improve Android compatibility.cpp-adapter.cppto usefbjnifor improved JNI registration and initialization.Example and Formatting Configuration
.eslintrc.js,.prettierrc.js). [1] [2] [3] [4] [5] [6] [7]biome.jsonconfiguration file for project-wide formatting and linting, replacing previous tooling.Funding and Project Metadata
.github/FUNDING.ymlfile to support multiple funding platforms.These changes modernize the library's API, improve Android and accessibility support, and update project configuration for better maintainability.