Fix flaky preferCallConnectionOverDeferredConnection test#9539
Open
kamilkrzywanski wants to merge 1 commit into
Open
Fix flaky preferCallConnectionOverDeferredConnection test#9539kamilkrzywanski wants to merge 1 commit into
kamilkrzywanski wants to merge 1 commit into
Conversation
Stall IPv6 by destination address in Socket.connect() instead of the first createSocket() call, which raced under concurrent connects. Fixes lysine-dev#9369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9369.
preferCallConnectionOverDeferredConnectiontries to force IPv4 to win the Happy Eyeballs race by stalling the competing connect, so IPv6 becomes a deferred plan and aREFUSED_STREAMretry reuses the call connection. It did that by stalling the firstcreateSocket()call.That was racy. Fast fallback launches connect work on separate threads, so under load the IPv4 thread could claim the stall while IPv6 proceeded. The request then hit IPv6 and failed with:
This stalls IPv6 specifically in
Socket.connect()when the destination islocalhostIpv6, so the right address is delayed no matter which thread runs first.