Use PEP 621 table form for project.license#2
Open
serge-wq wants to merge 1 commit intolyft-stable-1.26.0from
Open
Use PEP 621 table form for project.license#2serge-wq wants to merge 1 commit intolyft-stable-1.26.0from
serge-wq wants to merge 1 commit intolyft-stable-1.26.0from
Conversation
Lyft's s2ipythonlibrary builder venv pins setuptools==70.1.1, whose pyproject.toml schema validator enforces the pre-PEP-639 `oneOf` rule on `project.license` and rejects the SPDX shorthand (`license = "MIT"`). Downgrade the declaration to the PEP 621 table form and drop the PEP 639 `license-files` key so sdist/bdist_wheel succeeds on both old and new setuptools. The LICENSE file is still shipped through `setup.cfg` (`license_files = LICENSE`) and the maturin build config (`[tool.maturin].include = ["LICENSE"]`). Made-with: Cursor
serge-wq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlwith the older PEP 621 table form.