DM-49847: Turn off CTI for LATISS cp testing#65
Merged
Conversation
Alex-Broughton
force-pushed
the
tickets/DM-49847
branch
5 times, most recently
from
13f8670 to
329b5c0
Compare
erykoff
approved these changes
Oct 28, 2025
Contributor
erykoff
left a comment
erykoff
left a comment
There was a problem hiding this comment.
A couple of commented lines need to be removed; otherwise looks good
| if stage == "ptc": | ||
| args.append("-c cpPtcExtractPair:useEfdPhotodiodeData=False") | ||
| args.append("-c cpPtcAdjustGainRatios:max_adu=40000.0") | ||
| # args.append("-c cpPtcIsr:doDeferredCharge=False") # Turn off CTI |
Contributor
There was a problem hiding this comment.
Can you remove these commented lines?
| "-c cpBfkPtcSolve:maximumRangeCovariancesAstier=8 " | ||
| "-c cpBfkPtcSolve:maximumRangeCovariancesAstierFullCovFit=8 " | ||
| "-c cpBfkSolveX:doCheckValidity=False") | ||
| # "-c cpBfkIsr:doDeferredCharge=False") # Turn off CTI |
Alex-Broughton
force-pushed
the
tickets/DM-49847
branch
2 times, most recently
from
6ac4b5d to
cb4ff32
Compare
Contributor
|
Is the title of the PR correct? |
Alex-Broughton
force-pushed
the
tickets/DM-49847
branch
3 times, most recently
from
2759057 to
7bfd9dc
Compare
Alex-Broughton
force-pushed
the
tickets/DM-49847
branch
from
7bfd9dc to
a70ad3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.