[sw,dv] Fix SPI device SyncReqAckDataHoldSrc2Dst assertion failure#568
Closed
raylau1 wants to merge 1 commit into
Closed
[sw,dv] Fix SPI device SyncReqAckDataHoldSrc2Dst assertion failure#568raylau1 wants to merge 1 commit into
raylau1 wants to merge 1 commit into
Conversation
This fixes the address mode pending mask, and ensures the smoke test does not change the address mode multiple times without waiting for the pending bit to clear. This commit also adds blocking and non-blocking variants of function to set the address mode. The spi_device_init function uses the non-blocking variant to prevent spi_device_init from blocking forever in environments where there is no active SPI clock to clear the pending bit.
Contributor
Author
|
Closing this PR as the fix is in PR #387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
SyncReqAckDataHoldSrc2Dstassertion error in UVM.The address mode pending mask in the SPI device driver is corrected and the smoke test is updated to not change the address mode multiple times.
Closes #145