Emit room error before cleanup of room on js client #55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e45d664965
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Remove local room state so client does not auto-retry unless requested | ||
| this.cleanupRoom(msg.roomId, msg.crdt); | ||
| this.emitRoomStatus(roomId, RoomJoinStatus.Error); | ||
| this.cleanupRoom(msg.roomId, msg.crdt); |
There was a problem hiding this comment.
If an onStatusChange callback attempts to rejoin the room synchronously on RoomJoinStatus.Error, this new ordering emits the status while the room is still registered. join() short-circuits when it sees an active room (activeRooms.get(id) returns truthy), so the callback will get the stale room and no rejoin is issued, even though cleanupRoom runs immediately afterward. This only occurs when clients trigger a rejoin in the status callback, but it makes the documented “caller can rejoin manually” path unreliable. Consider cleaning up before emitting or temporarily allowing join to bypass the existing room in this error path.
Useful? React with 👍 / 👎.
1 participant
No description provided.