feat(graphql): migrate to type-graphql 2.0.0-rc.2#11418
Conversation
2ee0850 to
0a104fb
Compare
Pull Request Test Coverage Report for Build 21538622890Details
💛 - Coveralls |
4f9291c to
0885dfe
Compare
|
Hi @dhmlau, Could you please review this PR? |
dhmlau
left a comment
There was a problem hiding this comment.
@lchudinov, thanks for the PR. The changes look reasonable to me. I'm not familiar with this extension, so it would be ideal to have at least one more review before we land this PR.
Also, I have a question about one file. Thanks.
packages/cli/test/fixtures/copyright/single-package/src/application.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Leonty Chudinov <leonty.chudinov@gmail.com>
0885dfe to
226823c
Compare
|
@dhmlau, Thanks for your approval. Could you please add a reviewer who is familiar with the extension? |
|
@lchudinov , @raymondfeng is listed as codeowner for this extension. |
|
@dhmlau Sure, I agree. Waiting until next week sounds good. |
|
@lchudinov, thanks again for your contribution. Your PR has been merged! 🎉 |
[graphql] Migrate GraphQL Extension to type-graphql v2.0.0-rc.2
The GraphQL extension currently uses
type-graphqlversion2.0.0-beta.2.This PR migrates the extension to the latest release candidate,
2.0.0-rc.2.Checklist
npm testpasses on your machineexamples/*were updated