fix: #900 replace callback implementation by the promise one#901
Open
vvandens wants to merge 1 commit into
Open
fix: #900 replace callback implementation by the promise one#901vvandens wants to merge 1 commit into
vvandens wants to merge 1 commit into
Conversation
vvandens
force-pushed
the
fix/900-mongodb-callback
branch
from
fddd595 to
77f95d4
Compare
achrinza
force-pushed
the
fix/900-mongodb-callback
branch
from
77f95d4 to
24b3a47
Compare
Signed-off-by: Vincent Vandenschrick <vvandens@gmail.com>
vvandens
force-pushed
the
fix/900-mongodb-callback
branch
from
24b3a47 to
568b12b
Compare
achrinza
approved these changes
Jul 1, 2026
achrinza
left a comment
achrinza
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick PR turnaround! All LGTM 👍
I'll give the other maintainers an opportunity to review this PR if they wish. Otherwise, we'll proceed to merge this after ~one day.
Author
|
Perfect. |
Member
|
We can consider backporting to v7 if there's a use-case for it. From a cursory check, v8's only breaking change is dropping support for Node.js v20, which has already reached End of Life. Is there any particular blocker that's preventing an upgrade to v8? |
Author
|
Not our side. We can definitely upgrade to V8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from version 5, the mongodb node driver removed callback support in favor of promises only. This PR fixes the commit and rollback implementation of the connector.
No extra test needed. It is already covered by the transaction one (that is skipped...).
Fixes #900
Checklist
npm testpasses on your machine