add support for missing marker for bytes field in TypedDict#25
Merged
Conversation
giograno
approved these changes
Mar 27, 2026
Member
giograno
left a comment
giograno
left a comment
There was a problem hiding this comment.
Thanks for catching this and guiding me through the issue 💯
Luckily, this did not cause a big disruption for our schemas!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on SQS, I realized we had an issue with typed dict with
bytesfield and the missing marker, because Avro could not determine unions of bytes and string, it does not have a way to choose between the 2 types.And we'd get this error:
This PR implements behavior to properly generate schema and a new Missing marker type in bytes. Serialization and deserialization logic will need to be updated to take this into account.
I've already re-generated the schemas and validated that everything is working properly with this version