feat(ci): add GitHub Actions workflow and act support#14
Conversation
nik-localstack
force-pushed
the
unc-472-local-tests
branch
from
87aba3e to
1c4344d
Compare
nik-localstack
force-pushed
the
unc-472-ci
branch
from
ebb0387 to
0643c4b
Compare
nik-localstack
force-pushed
the
unc-472-local-tests
branch
from
1c4344d to
17640a3
Compare
nik-localstack
force-pushed
the
unc-472-ci
branch
from
0643c4b to
037d4d2
Compare
nik-localstack
force-pushed
the
unc-472-ci
branch
from
037d4d2 to
572461b
Compare
cloutierMat
left a comment
cloutierMat
left a comment
There was a problem hiding this comment.
LGTM. I left a couple questions but nothing blocking! Glad to have some CI here. Great first step before we can enable CI releases!
|
|
||
| services: | ||
| postgres: | ||
| image: postgres:16 |
There was a problem hiding this comment.
question: Any particular reason for using version 16?
There was a problem hiding this comment.
Not really, switching this to current major (18)
| options: >- | ||
| --health-cmd "pg_isready -U postgres" | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 5 |
There was a problem hiding this comment.
Question: Are the health checks of the postgres image not enough?
There was a problem hiding this comment.
Official postgres images (e.g., 17/18) do not define a Docker HEALTHCHECK by default. Define one explicitly so the GitHub Actions service waits for readiness.
There was a problem hiding this comment.
should we also add a linting step?
There was a problem hiding this comment.
Yes, but let's add it as a next step. wdyt ?
| ACT_PULL ?= false | ||
| ACT_CONTAINER_ARCH ?= linux/arm64 | ||
|
|
||
| test-act: ## Run the CI test workflow locally with act |
nik-localstack
force-pushed
the
unc-472-local-tests
branch
from
6125cff to
76050e8
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nik-localstack
force-pushed
the
unc-472-ci
branch
from
572461b to
0c35681
Compare
2 participants
Stacked on #13.
This PR adds a GitHub Actions CI workflow that runs the full test suite on Python 3.13, along with
actsupport for running the same workflow locally.Changes
.github/workflows/tests.yml: runs the full test suite on Python 3.13 via GitHub Actions.actrc: default flags for running the workflow locally withactMakefiletarget:test-act(runs the CI workflow locally viaact)README.mdtesting section withactinstructions