Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request modifies two UI component rendering methods in the spinner and progress components. One change adds styling to a progress label, while the other removes styling from spinner text. Both affect how text is rendered during component display. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
silv-io
left a comment
There was a problem hiding this comment.
Yep, makes way more sense like this!
This will change all other occurrences of the spinner, though (login, logout, etc.)
| label := fmt.Sprintf("%-11s %2d/%-2d layers", phase, done, total) | ||
| return fmt.Sprintf(" %s %s", | ||
| label, | ||
| styles.Secondary.Render(label), |
There was a problem hiding this comment.
Maybe we want to use the Secondary style for the percentage as well? We can do that in the bubbles.progress styles when creating it. WDYT?
See DES-152 for more context.