Skip to content

Make pulling output use primary colors#90

Open
gtsiolis wants to merge 1 commit intomainfrom
george/make-pulling-primary-output
Open

Make pulling output use primary colors#90
gtsiolis wants to merge 1 commit intomainfrom
george/make-pulling-primary-output

Conversation

@gtsiolis
Copy link
Member

@gtsiolis gtsiolis commented Mar 9, 2026

See DES-152 for more context.

BEFORE AFTER
Screenshot 2026-03-09 at 21 21 21 Screenshot 2026-03-09 at 21 19 25

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: dd8d9992-5854-458b-b72d-33955dc229e0

📥 Commits

Reviewing files that changed from the base of the PR and between cd3f6b3 and 39c7991.

📒 Files selected for processing (2)
  • internal/ui/components/pull_progress.go
  • internal/ui/components/spinner.go

📝 Walkthrough

Walkthrough

The pull request modifies two UI component rendering methods in the spinner and progress components. One change adds styling to a progress label, while the other removes styling from spinner text. Both affect how text is rendered during component display.

Changes

Cohort / File(s) Summary
UI Component Styling Updates
internal/ui/components/pull_progress.go, internal/ui/components/spinner.go
Modified View() methods to adjust text styling: pull_progress now applies Secondary style to phase labels, while spinner removes Secondary style from appended text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • carole-lavillonniere
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Make pulling output use primary colors' is directly related to the changes. The code modifications involve altering color styling in pull progress and spinner components.
Description check ✅ Passed The description includes before/after screenshots and references DES-152, demonstrating visual changes to the pulling output. It is clearly related to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch george/make-pulling-primary-output

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes way more sense like this!

This will change all other occurrences of the spinner, though (login, logout, etc.)

label := fmt.Sprintf("%-11s %2d/%-2d layers", phase, done, total)
return fmt.Sprintf(" %s %s",
label,
styles.Secondary.Render(label),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to use the Secondary style for the percentage as well? We can do that in the bubbles.progress styles when creating it. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants